Summary: | opening a file calls getImage 2 times on packageExplorer's label provider [package explorer] | ||
---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Adam Kiezun <akiezun> |
Component: | UI | Assignee: | Erich Gamma <erich_gamma> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | daniel_megert, dirk_baeumer, erich_gamma |
Version: | 2.1 | Keywords: | performance |
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Windows 2000 | ||
Whiteboard: |
Description
Adam Kiezun
2002-12-13 06:10:52 EST
The underlying items get replaced with working copy items. So the data pointers of the elements needs to be updated. Viewers are no supporting a flag to not refresh the item From Erich's comment I assume that there is nothing we can do. Is this right ? I meant that "now" there is a flag you can pass to refresh so that the icon isn't refreshed. StructureViewer.refresh(final Object element, final boolean updateLabels) This call could be leveraged to optimize this particular case. From looking at the implementation this flag doesn't seem to be be passed around. Also I cannot verify the refresh behaviour given the collapse/expand bug when opening a CU. I've release the change to call the new API. Dani FYI sind you are investigating into the collapse/expand bug Dani pls verify once the expand/collapse problem is fixed Still the same behavior. Reason: * The default implementation simply calls <code>internalRefresh(element)</code>, * ignoring <code>updateLabels</code>. According to Dirk there are plans to implement this for TreeViewers for 2.1. On open the second hit is caused by the ProblemsLabelDecorator which sends a refresh because it needs to update problem decorations based on the working copy. fixed |