Bug 282277

Summary:	CVS: Adding ignore whitespace option
Product:	[Eclipse Project] Platform	Reporter:	Edoardo Rossi <edoardo.rossi>
Component:	CVS	Assignee:	platform-cvs-inbox <platform-cvs-inbox>
Status:	ASSIGNED ---	QA Contact:
Severity:	enhancement
Priority:	P5	CC:	anne.jacko, markus.kell.r, pawel.pogorzelski1
Version:	3.5	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Edoardo Rossi

2009-07-02 07:37:10 EDT

We've been recently moved from a pure CVS command line usage to Eclipse with integrated CVS support. We normally creates a lot of patches and we code review every single patch we produce before committing the changes, therefore we always use the -w (ignore whitespace) flag on CVS command line in order to produce a more readable patch file to code review.

It will be great if you can add a tick box on the Team->CVS preferences in order to enable/disable this flag.

Comment 1 Eclipse Webmaster

2009-07-02 10:20:26 EDT

Re-assigning to Platform

-M.

Comment 2 Andrew Gvozdev

2009-07-02 14:08:37 EDT

(In reply to comment #0)
> It will be great if you can add a tick box on the Team->CVS preferences in order
> to enable/disable this flag.
There is one in preferences General>Compare/Patch tab. Is it what you are looking for?

Comment 3 Edoardo Rossi

2009-07-03 03:01:01 EDT

No, that one is just used when comparing files within Eclipse framework, what we are normally doing is to make the patch file using something like this:

cvs diff -U10 -w -N > filename.patch

then we attach the resulting patch file to the bug in Bugzilla ready for code review; this way another team of people will be able to look at the patch file directly within Bugzilla using the built in diff viewer.

What we need is the ability to generate patch file with the whitespace (-w) already being removed by CVS diff command, also to be absolutely perfect the ability to specify the number of context lines (-U10).

Comment 4 Pawel Pogorzelski

2009-08-03 06:09:42 EDT

This could be done either by adding two preferences (one for context lines and one for ignoring whitespaces) for CVS or by allowing to pass arbitrary parameters to the server. The latter option however introduces the possibility of passing parameters that would cause trouble on the Eclipse side.

As we don't plan to address the issue in the 3.6 cycle I'm lowering the priority and setting "helpwanted" on the bug.

Comment 5 Eclipse Webmaster

2019-09-06 16:03:53 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.