Bug 28226

Summary: Filtering method isValidEnvironment is not working properly
Product: [Eclipse Project] Platform Reporter: Pascal Rapicault <pascal>
Component: Update (deprecated - use Eclipse>Equinox>p2)Assignee: Christophe Elek <celek>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P1    
Version: 2.1   
Target Milestone: 2.1 M4   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Pascal Rapicault CLA 2002-12-12 18:35:11 EST 
The method isValidEnvironement is not working properly.
The parameters to isMatching() should be switched.
Moreover, it could be interesting if the matching rule 
could take into account some generic character.
Comment 1 Dejan Glozic CLA 2002-12-12 20:42:40 EST 
Pascal, I checked the code and it looks good to me. Why do you think it should 
be switched?
Comment 2 Christophe Elek CLA 2002-12-13 07:19:49 EST 
Action taken: based on the javadoc, Pascal seems right but...
The OS of the candidate can be a list  and the OS of the SiteManager can also be
a list. So the equalsIgnoreCase should be replace by indexOf()!-1, meaning at
least one OS of the candidate matches on OS of SiteManager
Can you elaborate on 'generic character' ? should it be a sperate enhancement PR
Action Plan: implement
Comment 3 Christophe Elek CLA 2002-12-13 07:30:48 EST 
Action Taken: implemented
Action Plan : Close