Bug 28031

Summary: closing 1 of two java editors flashes the menu bar
Product: [Eclipse Project] Platform Reporter: Adam Kiezun <akiezun>
Component: UIAssignee: Eduardo Pereira <eduardo_pereira>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: airvine
Version: 2.1Keywords: performance
Target Milestone: ---   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Adam Kiezun CLA 2002-12-10 11:31:19 EST 
closing 1 of two java editors flashes the menu bar

there's some optimization in that prevents the menu bar from flashing 
(that is, everytinh being deleted and recreated) when i open a second java 
editor

but it still flashes whene i close an editor

please put the same smartness: it can be computed which edioto will be visible 
after i close the current one - if it is the same editor (same kind), then do 
not recreate the whole menu bar from scratch
Comment 1 Adam Kiezun CLA 2002-12-10 11:33:29 EST 
one more agrument: closing an editor is very much like switchig editors 
(and switching does not flash either)
Comment 2 Eduardo Pereira CLA 2003-01-07 14:12:37 EST 
The problem is in WorkbenchPage.closeEditor(...). I commented out the lines:
//	// Deactivate part.
//	if (partWasActive)
//		setActivePart(null);
//	if (lastActiveEditor == editor) {
//		actionSwitcher.updateTopEditor(null);
//		lastActiveEditor = null;
//	}

They seem unnecessary. I will test it for a while before releasing it.
Comment 3 Eduardo Pereira CLA 2003-01-08 13:53:57 EST 
Released fix to the HEAD stream.
Comment 4 Eduardo Pereira CLA 2003-02-13 16:11:04 EST 
*** Bug 28119 has been marked as a duplicate of this bug. ***