Summary: | [dstore] Disconnect on idle causes the client hang | ||||||
---|---|---|---|---|---|---|---|
Product: | [Tools] Target Management | Reporter: | Masao Nishimoto <e03616> | ||||
Component: | RSE | Assignee: | David McKnight <dmcknigh> | ||||
Status: | RESOLVED FIXED | QA Contact: | Martin Oberhuber <mober.at+eclipse> | ||||
Severity: | critical | ||||||
Priority: | P1 | CC: | kjdoyle | ||||
Version: | 3.1 | Flags: | mober.at+eclipse:
pmc_approved+
kjdoyle: review+ |
||||
Target Milestone: | 3.1 RC3 | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | |||||||
Bug Depends on: | |||||||
Bug Blocks: | 278619 | ||||||
Attachments: |
|
Description
Masao Nishimoto
2009-05-29 04:13:21 EDT
Ouch, this sounds bad. When the client "hangs" is there anything the user can do to get it work again or is all of Eclipse dead? The user cannot do anything, and kills the workbench from the task manager. Ouch. We cannot allow this into 3.1 and better fix ASAP. Dave can you handle this? Masao, this is on Windows with 3.1RC? Masao, are you able to reproduce this with just base-RSE (i.e. not a z/OS connection)? What value do you give DSTORE_IDLE_SHUTDOWN_TIMEOUT? The version in use is 3.0.3. The first problem does not occur with Unix or REXEC, where the server is terminated by System.exit() on disconnect, and the socket is closed implicitly. Created attachment 137846 [details]
patch to disconnect when in single-server mode as well as check for isConnected() in statusmonitor
Masao, does this patch help?
I've opened bug 278619 for the backport to the RSE 3.0.3+ maintenance branch. Kevin, could you review this please? Review +. Thanks Kevin, I've committed the fix to cvs. I tried the fix, and confirmed it works good. The code in CVS ServerCommandHandler v1.12 line 63 doesn't match the patch attached here: if (_serverTimedOut) { System.out.println("server timed out"); Please review whether the System.out.println() is appropriate at this point. (In reply to comment #13) > The code in CVS ServerCommandHandler v1.12 line 63 doesn't match the patch > attached here: > > if (_serverTimedOut) > { > System.out.println("server timed out"); > > > Please review whether the System.out.println() is appropriate at this point. > The print was used for testing. I've taken that out now and recommitted. |