Summary: | Need to apply consistent branding for features in about box | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [WebTools] WTP Releng | Reporter: | David Williams <david_williams> | ||||||||||
Component: | releng | Assignee: | David Williams <david_williams> | ||||||||||
Status: | RESOLVED FIXED | QA Contact: | David Williams <david_williams> | ||||||||||
Severity: | normal | ||||||||||||
Priority: | P3 | CC: | manderse, neil.hauge, tranle1 | ||||||||||
Version: | unspecified | Flags: | david_williams:
pmc_approved?
(raghunathan.srinivasan) david_williams: pmc_approved? (naci.dai) david_williams: pmc_approved? (deboer) neil.hauge: pmc_approved+ david_williams: pmc_approved? (kaloyan) |
||||||||||
Target Milestone: | --- | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | Windows XP | ||||||||||||
Whiteboard: | PMC | ||||||||||||
Attachments: |
|
Description
David Williams
2009-05-24 03:06:23 EDT
Created attachment 136905 [details] chagnes made for javaScript Note: the icon image isn't included in patch, but comes from bug 273772. Also, there might be a few extra changes in JavaScript ... I noticed it didn't have an udpate site for some reason, so added that. Created attachment 136906 [details]
changes made for xml
Created attachment 136907 [details]
In general, outline of steps to follow to brand a feature for WTP
Marking for "PMC Approval", though not exactly the normal process. It unfortunately changes UI, and will be a late breaking change to some assembly featuers (org.eclipse.jst and org.eclipse.wst) but I think we really need the change ... have for a long time, so the cost will be worth it. When I saw our out of date our display was, it's no wonder, perhaps, people are biased to think we are "too big" since 'wst' and 'jst' are still be primary features displayed there! I'll be glad to revert, if someone comes up with a reason we should. Thanks, Created attachment 136934 [details]
improved instructions
Most significant change was that I previously forget to include the "about.mappings" file.
I've basically fixed all the remaining ones that had the "old" style feature branding. I also fixed those for which I'm a committer. Those components may want to check if they want to improve description, or anything else ... but I think there's nothing remaining that _has_ to be fixed this release. That leaves 4 features listed on update site, that I do not think currently have any "feature branding". It is not "stop ship" to fix those, imho, ... but, if anyone wants to you can follow the pattern set forth here. See xml ui feature and plugin for example. Those four that appear on update site, but not in "about box" are apache myfaces, webpage editor, and the two dali features. Feel free to ask questions if anything is not clear. Note for those wanting to do additional work to "brand features" I've put in a template plugin that contains the instructions and standard files and formats for WTP in a plugin in cvs. It is not to be used directly, but might make "getting the files" easier. I've also included there the instructions in a file called "stepByStepInstructions.txt" Check out org.eclipse.wtp.feature.branding.template from webtools.releng/plugins/ David, We had a branding plugin before but we dropped it because of the bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=245803 I think the issue was that it was referred from an assembly features therefore it was ignored once Dali was zipped. Do you suggest that we reintroduce it? in that case I guess we should refer it from the org.eclipse.jpt.feature. Thanks. Yes, I've learned that, basically, branding plugins for features should always be 'included' in the feature that they are branding. You can re-introduce it, or just modify one of your existing ones if easier, and appropriate. The important thing will be to use the common icon, and common provider name. (That is, even if you use the old one, you'll need to change it). Won't this create a gigantic about box for a default galileo ? At JBoss Tools we were branding our features too, but recently we stopped doing it or at least reduced it to one since the about box gets overcrowded *very* quickly if every feature-group gets a dominant icon on the about page. I think the Galileo requirements were met, so closing as 'fixed'. |