Summary: | [breadcrumb] Rename "View Mode" sub-menu and other breadcrumb related actions in Debug view | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Pawel Piech <pawel.1.piech> | ||||
Component: | Debug | Assignee: | Samantha Chan <chanskw> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | chanskw, darin.eclipse | ||||
Version: | 3.5 | Keywords: | polish | ||||
Target Milestone: | 3.5 RC1 | Flags: | darin.eclipse:
review+
|
||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Pawel Piech
2009-05-05 13:22:30 EDT
Sam, do you approve of this for RC1? I think these are good polish items. +1 from me to try to address this for RC1. 1) I like the idea of renaming View Mode to Layout to make it consistent with other views. 2) I am also ok with using breadcrumb and tree in the label, although I find Full and Compact more intuitive. I don't think many people understand what breadcrumb means, whether it's from JDT or from us. 3) I think the label for the "Auto-Expand" action is too long. This issue can be more serious in translated products. The translations can be much longer then the original string. What about "Auto-Expand Breadcrumb"? Would that be too confusing? I am wondering if it's too heavy weight to put this in a preference page, and have an action in the drop down that links to the preference page. Since breadcrumb can be enabled by resizing, I don't think many people will need to use the actions frequently. Having it in the preference page gives us more freedom on how to explain these concepts, and come up with more meaningful labels? Created attachment 134642 [details] Patch with fix. (In reply to comment #2) This patch (just the properties file) renames contains the changes including the "Auto-Expand Breadcrumb" label. I also agree that the name is too long and I'm starting to think that no matter how long the label it's still going to be confusing. It would be easier to explain it if the action was closer to the affected UI, like in the context menu in the drop-down itself, but that would e a lot of work just for a single action. In the end I suppose that we'll need to rely on help to clarify what this thing is for... and that's what I'm working on now. > I am wondering if it's too heavy weight to put this in a preference page, and > have an action in the drop down that links to the preference page. Since > breadcrumb can be enabled by resizing, I don't think many people will need to > use the actions frequently. Having it in the preference page gives us more > freedom on how to explain these concepts, and come up with more meaningful > labels? I suspect that there is some guideline against putting view-specific preferences in the preference pages. Besides, if it's even further removed from the affected UI, it would be harder to explain still. With the two approvals, I committed the change. Samantha, please verify. I see, I guess I'm supposed to use the review flag in addition to assigning the bug for verify. Darin, please review. Verified. Verified. |