Bug 274686

Description Kevin McGuire 2009-05-01 15:21:10 EDT

3.5 M7 candidate I20090430-2300

As part of bug #273147 we corrected the nesting of exceptions during builds (the nesting part of the fix was released but the status is still warning so the bug was not closed).

See attached pic, comparing results of throwing Assert.isTrue(false) in both M6 and the candidate M7 build.

Observations:

1) You can no longer see from the log the type of failure (in this case, assertion).  You can if you open the stack trace though.  

This was an intentional change in bug #273147 but now I'm wondering if it was the right one. A positive part of the change though is that previously the assertion failure was a sibling of the "error in builder X" status and this was confusing. Also previously the "error in builder X" exception had no stack trace so was of questionable value. But I think it's a loss of important information knowing what caused the build failure.  An alternative is that the assertion status be a child of the "error in builder X" multistatus.

2) In both M6 and today we have a trailing "Problems occured when invoking code from plug-in:xxx" error status.  Do we need this?  I actually find it misleading since it sort of suggests a problem with the plug-in org.eclipse.core.resources.  There's nothing wrong with the plug-in, the problem was with the 3rd party builder. It provides no additional information than "Errors during build", and in fact the stack trace is identical to the one in "error in builder X".

I'm thinking we should remove this status.