Bug 272726

Summary:	[ErrorHandling] Build errors should result in Status Dialog
Product:	[Eclipse Project] Platform	Reporter:	Kevin McGuire <Kevin_McGuire>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	krzysztof.daniel, prakash, Szymon.Brandys
Version:	3.5
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Kevin McGuire

2009-04-17 12:30:00 EDT

In investigation bug #272371 I noticed that there is no status dialog for build errors, they just go by silently (there's likely pre-existing a bug for this which must hunt down).

The reason there is no notification is that Worker.run() catches the errors and calls RuntimeLog.log(result).  We have a listener on the log which produces statuses and calls the status manager, but the default behaviour is to not show the dialog. See StatusManagerLogListener.logging() which does:

	handle(status, StatusManager.NONE);

For the dialog to appear, it'd need to be:
	handle(status, StatusManager.SHOW);

but I don't think we shouldn't throw up a dialog to the user on ever logged error (we may end up over-notifying for things which actually aren't serious). 

However, I think it's probably correct to always notify user via open status dialog for errors in jobs.  This would require  Work.run() to directly notify the status framework instead of relying on the catch all logging.  

If we decided we didn't want to notify of all job errors, we could watch specifically for build errors, either in Worker.run() or the StatusManagerLogListener.

Finally, a fancier approach would be a product level table mapping error types to notification flag.

Comment 1 Kevin McGuire

2009-04-17 13:19:26 EDT

(In reply to comment #0)
> In investigation bug #272371 I noticed that there is no status dialog for build
> errors, they just go by silently (there's likely pre-existing a bug for this
> which must hunt down).

Couldn't find a pre-existing/related bug.

Comment 2 Kevin McGuire

2009-04-17 13:49:08 EDT

(In reply to comment #0)

> The reason there is no notification is that Worker.run() catches
> the errors and calls RuntimeLog.log(result). 

Another path is SafeRunner.handleException.

This suggests that StatusManagerLogListener or later is the better place to differentiate handling of build error notification, thus catch all ways in.

Comment 3 Eclipse Webmaster

2019-09-06 15:32:22 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 4 Eclipse Webmaster

2019-09-06 15:38:25 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.