Bugzilla – Full Text Bug Listing
| Summary: | [assist] Keywords are not proposed in a for statement without block | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | David Audel <david_audel> | ||||||
| Component: | Core | Assignee: | Srikanth Sankaran <srikanth_sankaran> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | Olivier_Thomann | ||||||
| Version: | 3.5 | ||||||||
| Target Milestone: | 3.5 M7 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 129967 [details]
Proposed fix & tests
David, Thanks for your review.
The fix looks good. In the regression tests you should not use CompletionTestsRequestor but CompletionTestsRequestor2. CompletionTestsRequestor is obsolete. It checks less properties of each proposal, so is less accurate. I did not add a deprecated tag on CompletionTestsRequestor because it would add a lot of warnings in the problem views. I will add a comment on CompletionTestsRequestor to inform that this class must not be used anymore. Created attachment 130200 [details]
Revised patch
Revised patch to use CompletionTestsRequestor2 in place
of CompletionTestsRequestor.
Released in HEAD for 3.5M7.
(Thanks for the review comments!)
Released in HEAD for 3.5 M7 Verified for 3.5M7 using I20090426-2000 |
build I20090317-1745 1) create Test.java public class Test { void foo() { for(;;) ret| // do ctr+space at | } } 2) do ctrl+space at | The 'return' keyword is not proposed. The same problem occurs with other keyword (assert, if, try, ...)