Summary: | testInitJDTPlugin() seems to leak several DeltaProcessor and JavaModelManager | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | David Audel <david_audel> | ||||
Component: | Core | Assignee: | David Audel <david_audel> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | frederic_fusier, srikanth_sankaran | ||||
Version: | 3.5 | Keywords: | performance | ||||
Target Milestone: | 3.5 M7 | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | |||||||
Bug Depends on: | |||||||
Bug Blocks: | 260739 | ||||||
Attachments: |
|
Description
David Audel
2009-03-20 04:57:53 EDT
Created attachment 129427 [details]
Proposed fix
This patch set null the DeltaProcessor of the main thread when the test simulates restart. The other DeltaProcessors will disappear when their thread will disappear.
It should solve the leak in the performance test.
I released the fix in HEAD for 3.5. It fix only the problem in the performance test but the problem could also occur when jdtcore is restarted. Even if it is not a common case we should also fix it. (In reply to comment #1) > Created an attachment (id=129427) [details] > Proposed fix > > This patch set null the DeltaProcessor of the main thread when the test > simulates restart. The other DeltaProcessors will disappear when their thread > will disappear. > > It should solve the leak in the performance test. > And also while running JDT/Core mode tests (see bug 260739) Fix the problem in jdtcore would require too much modifications for an almost useless benefit because the restart of jdtcore never occurs. The fix for the tests is sufficient. I close this bug as FIXED. Verified for 3.5M7 using I20090426-2000 |