Bugzilla – Full Text Bug Listing
| Summary: | [plan] [3.5] [patch] Allow binary cycles in plugins with aspectj support | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] AJDT | Reporter: | Ivica Loncar <iloncar.ml> | ||||
| Component: | UI | Assignee: | AJDT-inbox <AJDT-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | andrew.eisenberg, daniel.rampanelli, gaston.tonietti | ||||
| Version: | 1.6.4 | ||||||
| Target Milestone: | 2.0.1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 282391 | ||||||
| Attachments: |
|
||||||
Thanks for the patch. It looks reasonable. It is too late for 1.6.4, but I will be able to include this in 1.6.5. This looks like a patch for AJDT 1.7. This does not compile on AJDT 1.6, or am I missing something? It is a diff against PDE imported 1.6.3 source bundles. I didn't checkout AJDT from SCM so it probably doesn't apply cleanly. Andrew, you're right! I have just fetched AJDT 1.6 and figured out I cannot apply this patch because I have also applied patches to: org.eclipse.pde.core org.eclipse.pde.ui org.eclipse.pde.build Since this relies on a newer version of org.eclipse.pde.internal.core.exports.FeatureExportInfo it will not work with vanilla eclipse 3.4.x This feature relies on features found in 3.5.x so it's a candidate for AJDT 1.7.x About to commit a variant of this patch. There really should be a UI component (just like there is for the JDT Feature Export Operation) so that a user can turn off binary cycles. Patch submitted Dev build in 3.5 stream now available. *** Bug 287273 has been marked as a duplicate of this bug. *** |
Created attachment 128840 [details] patch that sets IBuildPropertiesConstants.PROPERTY_ALLOW_BINARY_CYCLES in generator Eclipse 3.4 already has limited support for binary cycles in plugins (it is available if building from ant build file). Eclipse 3.5 provides GUI support for alloowing cycles in binary plugins. AJDT "borrows" FeatureExport code from eclipse PDE so it shouldn't be difficult to add same functionality to AJDT. Reason: We're using equinox aspects with spring dynamic modules (spring OSGI). Spring dynamic modules recommends usage of slf4j libraries for logging. There is a well known cyclic dependency related to slf4j bundles. In order to build our plugin with aspectj support we need to allow binary cycles. Here is a VERY SIMPLE patch that will silently allow binary cycles when exporting plugins with aspectj support.