Bugzilla – Full Text Bug Listing
| Summary: | API - Tag drop needs to be decoupled from the palette entry | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] Java Server Faces | Reporter: | Cameron Bateman <cameron.bateman> | ||||||||||||
| Component: | Core | Assignee: | Cameron Bateman <cameron.bateman> | ||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||
| Severity: | normal | ||||||||||||||
| Priority: | P1 | CC: | david_williams, gerry.kessler, raghunathan.srinivasan | ||||||||||||
| Version: | 3.1 | Keywords: | api | ||||||||||||
| Target Milestone: | 3.1 RC1 | Flags: | david_williams:
pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai) deboer: pmc_approved+ raghunathan.srinivasan: pmc_approved? (neil.hauge) raghunathan.srinivasan: pmc_approved? (kaloyan) raghunathan.srinivasan: review+ |
||||||||||||
| Hardware: | PC | ||||||||||||||
| OS: | Windows XP | ||||||||||||||
| URL: | ORACLE_P1 | ||||||||||||||
| Whiteboard: | PMC_approved | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Cameron Bateman
* Explain why you believe this is a stop-ship defect. Or, if it is a
"hotbug" (requested by an adopter) please document it as such.
This is a hot-bug requested by Oracle. The fix is required to support drop customization feature in the adopter product.
* Is there a work-around? If so, why do you believe the work-around is
insufficient?
No.
Approved assuming this is an API addition (i.e. non-breaking) based on Raghu's comments off-line. If it does require breakage please revisit whether it needs notification for adopters or approval. Created attachment 134034 [details]
Decouples TagToolPaletteEntry from everything except the palette itself.
Created attachment 134190 [details]
Code changes
Created attachment 134191 [details]
Test patch
PMC, We couldn't make these changes in time for M7 and so would like to get this in for RC1. Please review the attached patch. -Raghu The following announcement was made in the newsgroup, http://dev.eclipse.org/mhonarc/lists/wtp-jsf-dev/msg00345.html Who is affected: All Web Page Editor adopters who are implementing IElementEdit's. If you are following the API spec and only creating IElementEdit's by subclassing AbstractElementEdit then you will not be immediately affected but will want to switch over to the new method at some point during the deprecation period (two major releases after Galileo). What: A change will be made to IElementEdit to add a new method getDropCustomizer(IDropSourceData) and the existing getDropCustomizer(TagIdentifier tagId) will be deprecated. In AbstractElementEdit, the new method will by default call the deprecated method to ensure currently behaviour is preserved. When: The change will impact adopters starting in the Galileo release. Reference: https://bugs.eclipse.org/bugs/show_bug.cgi?id=267962 Please comment on the reference bug if you have adopter issues. Thanks, Cameron Bateman JSF Tools Team Created attachment 134330 [details]
Addresses issues raised in Gerry's review
Minor change that changes IDropSourceData so that it is abstracted from the direct concept of tags by renaming uri to namespace (this was Raghu's suggestion) and pushing tagName down to the IDropSourceData.
This change does not impact API any further than the original patches.
Created attachment 134332 [details]
Updated tests patch for new code patch
Affects JUnit tests only.
I have reviewed and tested the patches extensively, and this looks good. Patch applied to HEAD (3.1 stream). |