Summary: | Can't compile package-info.java from FindBugs with 3.5 Eclipse | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Andrey Loskutov <loskutov> | ||||||||
Component: | Core | Assignee: | Kent Johnson <kent_johnson> | ||||||||
Status: | VERIFIED FIXED | QA Contact: | |||||||||
Severity: | major | ||||||||||
Priority: | P3 | CC: | lenik, Olivier_Thomann, philippe_mulet, srikanth_sankaran | ||||||||
Version: | 3.5 | ||||||||||
Target Milestone: | 3.5 M6 | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows XP | ||||||||||
Whiteboard: | |||||||||||
Attachments: |
|
Description
Andrey Loskutov
2009-02-03 17:57:15 EST
(In reply to comment #0) > c) Select 2 children of the <trunk> element (hold CTRL key): > <trunk> > | > +- findbugs > Click [Next] What 2 children ? findbugs and ? Sorry, it was a "copy and paste" from http://code.google.com/p/findbugs/source/browse/trunk/eclipsePlugin/doc/building_findbugsplugin.txt?r=10519 You just need findBugs project, it is self-contained. Created attachment 125166 [details]
Proposed patch
We cannot resolve all annotations in a package-info.java file until after types know their fields/methods, but we can check for the deprecated annotation.
Created attachment 125407 [details]
Updated patch and testcase
Fix and test released for 3.5M6 Verified for 3.5M6 using I20090309-0100: the 'findbugs' project compiles without any error. (In reply to comment #4) > Created an attachment (id=125407) [details] > Updated patch and testcase > The test case released in this patch does concern bug 258906 and not this one. I verified that it passes with or without this bug fix, hence there's currently no regression test for this peculiar issue. However, I do not know if it was possible to write one though. *** Bug 267765 has been marked as a duplicate of this bug. *** |