Bug 26251

Summary: project compiler settings : some are not set
Product: [Eclipse Project] JDT Reporter: Adam Kiezun <akiezun>
Component: CoreAssignee: Philipe Mulet <philippe_mulet>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: martinae
Version: 2.0   
Target Milestone: 2.1 M4   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Adam Kiezun CLA 2002-11-14 05:40:12 EST
20021113
- add new task tags to the workspace compiler settings 
- remove them all for one of the projects - rebuild happens
- reopen the project's properties, look at settings - all task tags are still 
there
Comment 1 Martin Aeschlimann CLA 2002-11-14 12:14:28 EST
A JCore problem:
IJavaProject.setOptions() uses setPreferences which looks at a value to set, 
compares it with the default value. If it's the same it stores 'null'.

However, 'null' means, take it from the workspace settings, but that's not what 
I meant. The workspace settings could change, and I still want the project 
setting to have the specific setting.
Comment 2 Philipe Mulet CLA 2002-11-18 06:47:29 EST
This is the standard story for preferences. No preference means use defaults.
Maybe this should be better documented. 
Comment 3 Martin Aeschlimann CLA 2002-11-18 10:17:26 EST
For the project specific settings null has a different meaning:
Use the _workspace_ settings.

Note that I want to express: Use project specific setting 'xx'. 
Comment 4 Philipe Mulet CLA 2002-11-20 13:08:39 EST
We should probably introduce an extra possible value: "Workspace Default" to 
identify this scenario.
Comment 5 Martin Aeschlimann CLA 2002-11-21 03:46:50 EST
I think the current design is fine, just change the implementation to an own 
preference store that does not clear a setting if it is equal to it's default.

Comment 6 Philipe Mulet CLA 2002-12-02 09:04:53 EST
Fixed.
Comment 7 David Audel CLA 2002-12-17 10:33:23 EST
Verified.