Bug 258752

Summary: DirectedGraphLayoutAlgorithm disabled some DirectedGraphLayout functionality
Product: [Tools] GEF Reporter: Richard Miskin <r.p.miskin>
Component: GEF-Legacy ZestAssignee: gef-inbox <gef-inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: irbull
Version: 3.4   
Target Milestone: ---   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Attachments:
Description Flags
Remove ExtendedDirectedGraphLayout none

Description Richard Miskin CLA 2008-12-14 08:49:18 EST
Created attachment 120409 [details]
Remove ExtendedDirectedGraphLayout

Build ID: I20080617-2000

Steps To Reproduce:
Currently the DirectedGraphLayoutAlgorithm disables functionality in DirectedGraphLayout that spreads out GraphNodes horizontally. This leads to a graph that has all the nodes in a single column. 

More information:
If DirectedGraphLayout is used instead of ExtendedDirectedGraphLayout then, for my usage at least, the layout is better. If there is a need for ExtendedDirectedLayout maybe the constructor to DirectedGraphLayoutAlgorithm  could have an extra parameter?

I've attached a patch that simply removes ExtendedDirectedGraphLayout, if something more intelligent is wanted let me know.
Comment 1 Ian Bull CLA 2009-01-05 01:31:18 EST
This is used in the PDE visualization tool, we use the directed graph layout to get the row ordering, then we move the nodes manually.  This is much faster then using the default directed graph layout (it is very smart with respect to column ordering, and thus very slow).  

I will look at this patch, and see if we can maybe create two different layout algorithms to make both cases work.


Comment 2 Alexander Nyßen CLA 2015-01-22 02:44:42 EST
Re-assigning back to inbox, as Ian is no longer active committer.