Summary: | Class file editor uses non-standard modifier order | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Jim des Rivieres <jeem> | ||||
Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | minor | ||||||
Priority: | P3 | ||||||
Version: | 2.1 | ||||||
Target Milestone: | 3.1 M5 | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Jim des Rivieres
2002-11-06 15:46:26 EST
It's the editor which shows up when no source is attached. Decreasing severity to 'minor'. This is provided by the Disassembler: String content= null; int flags= IClassFileReader.FIELD_INFOS | IClassFileReader.METHOD_INFOS | IClassFileReader.SUPER_INTERFACES | IClassFileReader.METHOD_BODIES; IClassFileReader classFileReader= ToolFactory.createDefaultClassFileReader(classFile, flags); if (classFileReader != null) { IClassFileDisassembler disassembler= ToolFactory.createDefaultClassFileDisassembler(); content= disassembler.disassemble(classFileReader, "\n"); //$NON-NLS-1$ } Created attachment 17335 [details]
Reorder the modifiers and a bit of clean-up
Reordered the modifiers according to JLS.
Cleaned the code a bit by extracting a common routine.
I will review it. Thanks for the patch. Fixed and released in HEAD. Updated existing regression tests. Verified in I20050215-2300 |