Bug 256409

Summary: PDE Spy should show type of selection
Product: [Eclipse Project] PDE Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Chris Aniszczyk <caniszczyk>
Status: VERIFIED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: caniszczyk, contact
Version: 3.5Keywords: bugday, noteworthy
Target Milestone: 3.5 M5   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
A present from Dani none

Description Dani Megert CLA 2008-11-25 06:06:57 EST
N20081124-2000.

The PDE Spy only shows the selection info if it is an IStructuredSelection. It should always show that section and show whether it is 'null' or which type it has. For ITextSelection it could also show the selected text.

Code to enhance is org.eclipse.pde.internal.runtime.spy.sections.ActiveSelectionSection.build(ScrolledForm, SpyFormToolkit, ExecutionEvent)
Comment 1 Dani Megert CLA 2009-01-28 09:46:28 EST
Created attachment 124025 [details]
A present from Dani
Comment 2 Chris Aniszczyk CLA 2009-01-28 09:47:34 EST
Thanks Dani!

Now I owe you, and I know which bug you want fixed ;)
Comment 3 Chris Aniszczyk CLA 2009-01-28 10:07:27 EST
done.

> 20090128

Note that we don't show the text for text selections still but that's fine.
Comment 4 Dani Megert CLA 2009-01-28 10:11:26 EST
>Note that we don't show the text for text selections still but that's fine.
Yes, and also not the type of selected elements if > 1. I thought of a details button/link but that would have exploded my time budget ;-)
Comment 5 Dani Megert CLA 2009-01-29 02:48:36 EST
Verified in I20090128-1800.