Bug 25635

Summary:	Applying patch creates wrong folder structure
Product:	[Eclipse Project] Platform	Reporter:	Nick Edgar <n.a.edgar>
Component:	Compare	Assignee:	Platform-Compare-Inbox <platform-compare-inbox>
Status:	RESOLVED DUPLICATE	QA Contact:
Severity:	normal
Priority:	P3
Version:	2.1
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Nick Edgar

2002-11-01 11:53:50 EST

build I20021023

I was trying to apply the patch for bug 22621.
- in package explorer, selected JFace's Dialog.java
- compared with patch, etc.
- it compared OK, showing the difference properly
- hit Finish
- it created a new folder structure, replicating the path to the file under the 
dialogs folder:
org.eclipse.jface/src/org/eclipse/jface/dialogs/src/org/eclipse/jface/dialogs
- this contained Dialog.java and Dialog.java.rej
- the new Dialog.java had 0 bytes, Dialog.java.rej had essentially the same 
contents as the patch
- the original Dialog.java was unaffected

- went back and selected the project, org.eclipse.jface, instead of Dialog.java
- tried to apply the patch again
- this time it worked

Comment 1 Dani Megert

2002-11-14 02:50:27 EST

There is some indication that there's a path (because the patch was actually
created for/on the project.

It would have patched Dialog.java correctly if the "Ignore leading path name
segments" was 5.
The UI should automatically set the at value since it matched Dialog.java from
the patch with the one in the workspace. Another alternative would be to show no
match until the user correctly sets the leading segments value.

Not critical enough for 2.1-M3

Comment 2 Andre Weinand

2003-02-10 09:36:04 EST


*** This bug has been marked as a duplicate of 28840 ***