Bug 254887

Summary: Error in .log after deleting project
Product: [WebTools] WTP Common Tools Reporter: Tim deBoer <deboer>
Component: wst.commonAssignee: Chuck Bridgham <cbridgha>
Status: RESOLVED FIXED QA Contact: Konstantin Komissarchik <konstantin>
Severity: normal    
Priority: P1 CC: cbridgha, ccc, david_williams, jacek.pospychala
Version: 3.0.3Flags: david_williams: pmc_approved+
cbridgha: pmc_approved? (raghunathan.srinivasan)
cbridgha: pmc_approved? (naci.dai)
cbridgha: pmc_approved? (deboer)
cbridgha: pmc_approved? (neil.hauge)
cbridgha: pmc_approved? (kaloyan)
ccc: review+
Target Milestone: 3.0.4   
Hardware: PC   
OS: Windows XP   
Whiteboard: PMC_approved
Attachments:
Description Flags
patch none

Description Tim deBoer CLA 2008-11-11 09:16:10 EST 
After deleting a project from the workspace, the following error appeared in the .log file. Please fix this NPE so that unnecessary errors are not output to the .log.

!ENTRY org.eclipse.core.jobs 4 2 2008-11-10 22:34:12.468
!MESSAGE An internal error occurred during: "J2EEComponentMappingUpdateJob".
!STACK 0
java.lang.NullPointerException
	at org.eclipse.wst.common.componentcore.internal.impl.ResourceTreeRoot.getDeployResourceTreeRoot(Unknown Source)
	at org.eclipse.wst.common.componentcore.internal.resources.VirtualResource.removeLink(Unknown Source)
	at org.eclipse.jst.j2ee.refactor.listeners.J2EEElementChangedListener$1.runInWorkspace(Unknown Source)
	at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(Unknown Source)
	at org.eclipse.core.internal.jobs.Worker.run(Unknown Source)
Comment 1 Konstantin Komissarchik CLA 2008-11-11 12:51:11 EST 
Chuck,

Could you take a look?
Comment 2 Chuck Bridgham CLA 2008-11-11 13:20:48 EST 
Created attachment 117575 [details]
patch
Comment 3 Chuck Bridgham CLA 2008-11-11 13:21:40 EST 
Protect against deleted project in background process
Comment 4 Chuck Bridgham CLA 2008-11-11 13:22:14 EST 
Carl adding you to review (for 3.0.4)
Comment 5 Chuck Bridgham CLA 2009-01-29 15:01:17 EST 
  This is an old bug that was "found" recently...


  * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This isn't stop-ship, but adopter requested

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

No

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

junit regression bucket has been run

    * Give a brief technical overview. Who has reviewed this fix? 

Some protective code checks in place in case the project has been deleted before 
 this thread has had any chance to run


    * What is the risk associated with this fix? 

None - only null checks
Comment 6 David Williams CLA 2009-01-29 15:19:47 EST 
having cleaner logs is important for anyone involved with service
Comment 7 David Williams CLA 2009-01-29 15:30:19 EST 
Chuck, my own feeling is that if this is important enough to request PMC approval for, then it is important enough for you to request a respin for. 

While not blocking, you should change priority to P1, meaning in your view we can't ship without it. 

Up to you ... just letting you know we want our release candidates as close as possible to the release.
Comment 8 Carl Anderson CLA 2009-01-29 16:24:23 EST 
Committed/released to R3_0_maintenance for 3.0.4 RC1