Bug 249567

Description Dmitriy Matveev 2008-10-03 01:37:58 EDT

There are two classes in different packages, but with equal names in that packages. package1.MyClass and package2.MyClass (they can be empty)
There one class with two fields of that types and two constructors taking single argument of one of these types.
Class with parsing problem:

public class MixedMethods
{
    private final package1.MyClass _fieldFromPackage1;
    private final package2.MyClass _fieldFromPackage2;

    MixedMethods(package2.MyClass o)
    {
        _fieldFromPackage1 = null;
        _fieldFromPackage2 = o;
    }

    MixedMethods(package1.MyClass o)
    {
        _fieldFromPackage1 = o;
        _fieldFromPackage2 = null;
    }
}

Type declaration node contain following children:

0: private final cfg.package1.MyClass _fieldFromPackage1;
1: private final cfg.package2.MyClass _fieldFromPackage2;
2: MixedMethods(cfg.package2.MyClass o){
  _fieldFromPackage1=null;
  _fieldFromPackage2=o;
}
3: MixedMethods(cfg.package1.MyClass o){
  _fieldFromPackage1=o;
  _fieldFromPackage2=null;
}

Our parse procedure is following:
1. Take methodBinding via IMethodBinding.resolveBinding() method.
2. Replace it by call to getMethodDeclaration() on it.
3. Invoke getJavaElement() method on it to get IMethod.

The 3rd action leads us inside Util.getUnresolvedJavaElement(MethodBinding, WorkingCopyOwner, BindingToNodesMap) method where correct IMethod is created and then similar method search is performed. findMethods member returns both constructors as similar methods and first of them is used, so we have incorrect IMethod for node with index 3. That happens because search procedure uses areSimilarMethods which performes method comparison by simple names instead of qully-qualified ones.