Summary: | [plan] Follow on incremental analysis for multi-project setups | ||
---|---|---|---|
Product: | [Tools] AspectJ | Reporter: | Andrew Clement <aclement> |
Component: | Compiler | Assignee: | aspectj inbox <aspectj-inbox> |
Status: | RESOLVED DUPLICATE | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | ||
Version: | DEVELOPMENT | ||
Target Milestone: | 1.6.4 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Whiteboard: |
Description
Andrew Clement
2008-09-30 16:32:03 EDT
Earlier on, you had introduced the method AsmManager.getModelChangesOnLastBuild(). When there is a change to an aspect on the aspect path, the files affected by it are *not* placed on this file, but they should be. The case described in comment 1 uncovered a bit of a mess. Analysis of class file changes on the aspectpath is rather incomplete and so I've fleshed it out. A change to a .class file on the aspectpath *which contained an aspect* will now trigger a full build. I think it previously got ignored, which is definetly not the right thing to do. This does mean we may suffer a performance degradation due to the full build but I need to play around with it in a real scenario and see if it is a real issue. I have some ideas for doing things properly but they are non-trivial. This should also address 246476 comment 13. Not going to make it for 1.6.3 the multi project incremental performance is now being addressed under bug 268827. That bug will cover optimizing for a chain of AspectJ projects and a chain where AspectJ projects depend on JDT projects. The issue of JDT projects depending on AspectJ projects will be the remaining case I haven't even tried - i dont know how slow that is. *** This bug has been marked as a duplicate of bug 268827 *** |