Bug 248384

Summary:	[JFace] IPageChangeProvider should not be "restricted" to dialogs
Product:	[Eclipse Project] Platform	Reporter:	Remy Suen <remy.suen>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	pwebster
Version:	3.5
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Remy Suen

2008-09-24 02:05:46 EDT

UA's FormEditor currently implements this interface to provide notifications for page switching and I think it may be possible for MPEP to consume this interface also (see bug 201391). One issue I see is that it is currently in the o.e.jface.dialogs package which doesn't give it a very "general" feel. Regrettably, the API specification also states it's for dialogs and not just for anything with pages. On the other hand, the person who designed the API was nice enough to make getSelectedPage() return an Object instead of an IDialogPage instance. Thanks Tod! See bug 87111 comment 18. :)

http://help.eclipse.org/stable/nftopic/org.eclipse.platform.doc.isv/reference/api/org/eclipse/jface/dialogs/IPageChangeProvider.html

Comment 1 Paul Webster

2008-10-02 15:32:43 EDT

Susan, is this something that we should consider generalizing away from dialogs, or simply something we could inject into the MPEP hierarchy?

PW

Comment 2 Susan McCourt

2008-10-06 19:10:16 EDT

(In reply to comment #1)
> Susan, is this something that we should consider generalizing away from
> dialogs, or simply something we could inject into the MPEP hierarchy?

In theory it seems more general. 
But in practice...since the only non-dialog implementor right now is already an MPEP subclass, I'd be inclined to use it in MPEP as is.  

If we had another case, esp. if it involved including jface.dialogs when otherwise the package would not be referenced, I'd be more inclined to say let's consider a more general solution.

Comment 3 Paul Webster

2008-10-07 08:46:13 EDT

(In reply to comment #2)
> (In reply to comment #1)
> > Susan, is this something that we should consider generalizing away from
> > dialogs, or simply something we could inject into the MPEP hierarchy?
> 
> In theory it seems more general. 
> But in practice...since the only non-dialog implementor right now is already an
> MPEP subclass, I'd be inclined to use it in MPEP as is.  

OK, I'm fine with exploring that option.

PW

Comment 4 Susan McCourt

2009-07-09 18:19:50 EDT

As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009

Comment 5 Eclipse Webmaster

2019-09-06 16:06:33 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.