Bug 248309

Summary:

[model] IAnnotatable#getAnnotations() does not work for standard annotations on binary members

Product:

[Eclipse Project] JDT

Reporter:

Markus Keller <markus.kell.r>

Component:

Core

Assignee:

Jerome Lanneluc <jerome_lanneluc>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Olivier_Thomann

Version:

3.5

Target Milestone:

3.5 M3

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

236850

Attachments:

Description	Flags
Proposed fix and regression tests	none
Corresponding jclMin1.5.jar for tests	none
Corresponding jclMin1.5src.zip for tests	none

Description Markus Keller

2008-09-23 13:15:51 EDT

I20080918-0100

IAnnotatable does not work for binary members. E.g. javax.annotation.Generated from JDK6 has no annotations in the Java model.

Comment 1 Jerome Lanneluc

2008-09-25 09:56:42 EDT

The support for standard annotations is indeed missing. User defined annotations work correctly.

We should check if ClassFileReader.getTagBits() contains a standard annotation (see TagBits.Annotation* constants).

Comment 2 Jerome Lanneluc

2008-10-23 07:15:52 EDT

Created attachment 115910 [details]
Proposed fix and regression tests

Comment 3 Jerome Lanneluc

2008-10-23 07:17:34 EDT

Created attachment 115911 [details]
Corresponding jclMin1.5.jar for tests

To put in /org.eclipse.jdt.core.tests.model/JCL/jclMin1.5.jar

Comment 4 Jerome Lanneluc

2008-10-23 07:18:23 EDT

Created attachment 115912 [details]
Corresponding jclMin1.5src.zip for tests

To put in /org.eclipse.jdt.core.tests.model/JCL/jclMin1.5src.zip

Comment 5 Jerome Lanneluc

2008-10-23 10:02:15 EDT

Fix and tests released for 3.5M3

Comment 6 Olivier Thomann

2008-10-27 15:41:19 EDT

Verified for 3.5M3 using I20081026-2000