Summary: | API enhancement request for org.eclipse.jpt.db.Column | ||||||
---|---|---|---|---|---|---|---|
Product: | [WebTools] Dali JPA Tools | Reporter: | Danny Ju <danny.ju> | ||||
Component: | Framework | Assignee: | Brian Vosburgh <brian.vosburgh> | ||||
Status: | RESOLVED FIXED | QA Contact: | |||||
Severity: | enhancement | ||||||
Priority: | P3 | CC: | brian.vosburgh, karenfbutzke, konstantin, neil.hauge | ||||
Version: | unspecified | Keywords: | plan | ||||
Target Milestone: | 2.1 M3 | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Danny Ju
2008-09-19 16:52:06 EDT
Created attachment 113051 [details]
Proposed patch
This seems reasonable, my only request is that you also look at adding to our unit tests. These can be found in org.eclipse.jpt.db.tests.internal.platforms Sure, can you point me to the CVS path of the unit tests? I did not find one named org.eclipse.jpt.db.tests. The plugin is in org.eclipse.jpa/components/jpa/tests/org.eclipse.jpt.db.tests. I'm not sure why they don't show up directly under the HEAD node, like most of the other plugins I applied Danny's patch, with a few modifications and additions. It was released and is now part of M2. I also added some JUnit tests; these are in HEAD and will be part of the forthcoming Dali 2.1 branch. To make the things more consistent, I changed some of the existing API in Column: dataTypeIsLOB() -> isLOB() isForeignKeyColumn() -> isPartOfForeignKey() isPrimaryKeyColumn() -> isPartOfPrimaryKey() Checked M2 and the APIs are added as expected. Thanks! I have another new requirement for the Column class: Column.isAutoIncrement() which should return if the column is using a auto incremented ID sequence. This one is not as straight forward as the ons above. I will create a new bug. |