Bug 246955

Summary:

Add API compatibility filter for ITypeRoot

Product:

[Eclipse Project] JDT

Reporter:

Dani Megert <daniel_megert>

Component:

Core

Assignee:

Jerome Lanneluc <jerome_lanneluc>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Olivier_Thomann, philippe_mulet

Version:

3.4

Target Milestone:

3.5 M2

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed fix	none

Description Dani Megert

2008-09-11 02:59:26 EDT

ITypeRoot

Comment 1 Dani Megert

2008-09-11 03:02:29 EDT

N20080910-2000.

I get an API tooling error on ITypeRoot because a restriction (api tooling tag) got added compared to 3.4. Given that the actual restriction was already documented in the Javadoc of 3.4, an API compatibility filter should be added for ITypeRoot (use quick fix) in order to get rid of the error.

Comment 2 Philipe Mulet

2008-09-11 04:45:15 EDT

The plan is to address all these for 3.5, but there are issues first to resolve in API tooling itself (e.g. it cannot blame extending internal type, and blame fixing it afterwards as binary change).

Comment 3 Philipe Mulet

2008-09-11 05:11:41 EDT

Dani's setup is:
- jdtcore as sources
- configured api tooling diagnosis as error (so it doesn't get unnoticed)

I think we should add the exemption, so we do not get a blame in integration build for a good change (non controversial).

Comment 4 Jerome Lanneluc

2008-09-12 12:50:17 EDT

Created attachment 112442 [details]
Proposed fix

Comment 5 Jerome Lanneluc

2008-09-12 12:52:08 EDT

Fix released for 3.5M2

Comment 6 Dani Megert

2008-09-13 03:59:17 EDT

Thanks Jérome!

Comment 7 Olivier Thomann

2008-09-15 09:58:40 EDT

Verified for 3.5M2 using I20080914-2000