Bug 244528

Summary:	Zoom combo should consider list length
Product:	[Tools] GEF	Reporter:	SANO Tateki <t-sano>
Component:	GEF-Legacy GEF (MVC)	Assignee:	gef-inbox <gef-inbox>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	hudsonr
Version:	3.4
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description SANO Tateki

2008-08-19 06:57:14 EDT

Build ID: I20080617-2000

Steps To Reproduce:
ZoomComboContributionItem does not treat Combo#setVisibleItemCount. Because of this, not all zoomings won't be displayed if more than 5 items are in the combo.
ZoomComboContributionItem should automatically calculate the number of items, or it should have either "setVisibleItemCount"  or "getCombo".

Comment 1 Randy Hudson

2008-08-21 10:03:15 EDT

Do you prefer that we define new API, or would you rather just suggest a visible item count that makes sense for all GEF clients?  I agree, the windows default of 5 is way too small, especially if you have 6 or 7 choices.

Comment 2 SANO Tateki

2008-08-22 00:41:53 EDT

I prefer ZoomComboContributionItem automatically calculates current item size and set it to the combo so that all items are shown. This is because toolbar pulldown with a vertical scrollbar is terrible.

I added three zoom level contributions (ZoomManager.FIT_*) and noticed this issue. I think at least 3 zoom levels must be provided, e.g. 50%, 100%, 200%, other than FIT_*.

So, 6 or 7 choices are usual case :)