Bug 241716

Summary: Handle change expired password
Product: [Tools] Target Management Reporter: Richie Yu <richieyu>
Component: RSEAssignee: David Dykstal <ddykstal.eclipse>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P2 CC: ddykstal.eclipse, kjdoyle, rdibugs
Version: 3.0Keywords: contributed
Target Milestone: 3.0.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
updates local variable to handle potential change in .validate ()
none
updates local variable to handle potential change in .validate ()
none
updates local variable to handle potential change in .validate ()
ddykstal.eclipse: iplog+
updates local variable to handle potential change in .validate ()
none
updates local variable to handle potential change in .validate () none

Description Richie Yu CLA 2008-07-22 13:43:29 EDT
Hi,

We're extending the validator.validate () method to handle changing expired password.  We need to be able to update the local variables in the dialogs that invoke this method.  Could we query the credentials variable after the validate?

Here's the snippet of requested changes:


In StandardCredentialsProvider class, acquireCredentials method

ICredentials credentials = getCredentials(); // new
     if (validator != null) {
	SystemMessage m = validator.validate(credentials); // new
	password = credentials.getPassword();  // new

In SystemPasswordPromptDialog class, processOK method
SystemSignonInformation(hostName, userId, password, systemType);
SystemMessage m = signonValidator.validate(credentials);
password = credentials.getPassword();  //new

Thanks,
Richie
Comment 1 Martin Oberhuber CLA 2008-07-23 10:23:54 EDT
Richie, it looks like you have a pretty good idea of what you want, could you attach a patch here that does what you need? - Please also add a comment indicating that you contribute the patch under EPL, see http://www.eclipse.org/dsdp/tm/development/committer_howto.php#external_contrib
Comment 2 Richie Yu CLA 2008-07-23 14:29:27 EDT
Created attachment 108245 [details]
updates local variable to handle potential change in .validate ()

I, Richie Yu, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. {I am authorized by my employer to make this contribution under the EPL.}
Comment 3 Richie Yu CLA 2008-07-23 14:31:00 EDT
Created attachment 108247 [details]
updates local variable to handle potential change in .validate ()

I, Richie Yu, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. {I am authorized by my employer to make this contribution under the EPL.}
Comment 4 Richie Yu CLA 2008-07-23 14:46:51 EDT
Created attachment 108250 [details]
updates local variable to handle potential change in .validate ()

I, Richie Yu, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. {I am authorized by my employer to make this contribution under the EPL.
Comment 5 Richie Yu CLA 2008-07-23 14:48:21 EDT
Created attachment 108251 [details]
updates local variable to handle potential change in .validate ()
Comment 6 Richie Yu CLA 2008-07-23 14:50:08 EDT
Created attachment 108252 [details]
updates local variable to handle potential change in .validate ()
Comment 7 David McKnight CLA 2008-07-31 11:32:20 EDT
Dave D, this is your area.  Can you deal with this patch?
Comment 8 David Dykstal CLA 2008-08-24 22:36:42 EDT
Applied the patch with minor modifications to comments.
Updated IP log file.
Comment 9 Martin Oberhuber CLA 2008-08-25 11:24:33 EDT
Dave can you please set a bugzilla "iplog+" flag on the attachment which you have actually used for the patch? For me, it looks like this would be the 3rd one and numbers 4 and 5 can be marked obsolete?