Bugzilla – Full Text Bug Listing
| Summary: | [formatter] Formatter do unexpected things | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Su Su <death228> | ||||
| Component: | Core | Assignee: | Frederic Fusier <frederic_fusier> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P2 | CC: | daniel_megert, david_audel, death228, jerome_lanneluc, Olivier_Thomann | ||||
| Version: | 3.4 | ||||||
| Target Milestone: | 3.4.1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Reproduced. The problem comes from the parser which does not record text start while consuming a opening brace. This was not necessary for other comment parsers, but is essential for the comments formatter parser! Created attachment 110466 [details]
Proposed patch
Released for 3.5M2 Jerome, as this is a regression since 3.3.2, is it OK to backport the fix to 3.4.1? +1 for 3.4.1 since this is a regression and there is loss of data. The proposed patch is the same for R3_4_maintenance branch code... Released for 3.4.1 Verified for 3.4.1 using M20080827-2000 Verified for 3.5M2 using I20080914-2000 |
After I press Ctrl+Shift+F to format the code. /** * <pre>{ }</pre> * * <table> * <tr>{ "1", * "2"} * </tr> * </table> */ becomes /** * <pre> * * </pre> * * <table> * <tr> * "1", "2"} * </tr> * </table> */ Two "{"s and one "}" are missing.