Bug 238847

Summary:	Improve performance of shell creation on GTK
Product:	[Eclipse Project] Platform	Reporter:	Bogdan Gheorghe <gheorghe>
Component:	SWT	Assignee:	Bogdan Gheorghe <gheorghe>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	raji, steve_northover
Version:	3.4
Target Milestone:	3.5 M1
Hardware:	PC
OS:	Linux
Whiteboard:

Description Bogdan Gheorghe

2008-06-27 16:49:43 EDT

We have a benchmark that did "new Shell()" that was slower on GTK than Windows.  Here is how we fixed it:

Shell creation on a single monitor system takes longer then it needs to. It calls gdk_screen_get_monitor_at_window() when there is only ever one monitor possible.  We optimized this case.

Comment 1 Bogdan Gheorghe

2008-06-27 16:59:09 EDT

Fixed in HEAD > 20080627

Comment 2 Steve Northover

2008-07-02 18:24:57 EDT

We need to rerun the benchmarks.

Comment 3 Raji Akella

2008-09-07 21:16:30 EDT

Is it possible to get a patch for 3.4?

Comment 4 Steve Northover

2008-09-08 12:17:00 EDT

It's not worth it.  Unless you are creating tons of shell, you won't see a difference.

Comment 5 Raji Akella

2008-09-08 14:08:00 EDT

I was asked to bring this in for Notes 8.5. I will take your recommendation back to them.. thanks.

Comment 6 Raji Akella

2008-09-10 12:32:16 EDT

Looks like we do create quite a lot. Some data was sent to you via email. Please evaluate and let me know if we would benefit from the patch.

Comment 7 Steve Northover

2008-09-10 18:54:03 EDT

I have no data, other than some benchmark code that was entered in another bug report that I cannot find right now (@#$%@#%).  Bogdan, we entered this bug report when we fixed one of the issues in the benchmark code that I am talking about.  Can you find the original bug report?  I searched on "performance", "slow" etc. and failed.

Comment 8 Steve Northover

2008-09-10 19:22:05 EDT

Ok, Bogdan please find the bug report anyways but I have found the data.

NOTE:  It is not common (but also not wrong in the open source sense) for clients of Eclipse or SWT to decide that they wish to communicate data about a bug report via email.  This can happen for any number of reasons, but like I said, it's not very common.

Comment 9 Raji Akella

2008-09-10 21:59:15 EDT

Yes, I understand. I would have liked the data and all communications to be posted here as well. It is easier to track.