Bugzilla – Full Text Bug Listing
| Summary: | org.eclipse.jpt.eclipselink_sdk.feature not optional as it should be | ||
|---|---|---|---|
| Product: | [WebTools] Dali JPA Tools | Reporter: | David Williams <david_williams> |
| Component: | General | Assignee: | Tran Le <tranle1> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | critical | ||
| Priority: | P3 | CC: | david_williams, karenfbutzke, neil.hauge, tranle1 |
| Version: | 2.0 | ||
| Target Milestone: | 2.0.1 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
| Bug Depends on: | 237668 | ||
| Bug Blocks: | |||
|
Description
David Williams
marking as critical since this could result in an "invalid configuration" for anyone "hand crafting" their own installation from our zip files. I suggest that the problematic features,
org.eclipse.jpt
org.eclipse.jpt.sdk
be deleted (not just renamed)
because their names are so confusing with the 'real' features.
Then, replace them features where the feature ID (and the project name) has "assembly" in the name. Our scripts (see buildutilities.xml) are written so any feature with "assembly" anywhere in the id is removed automatically from the zip files.
So, the new ones would be something like
org.eclipse.jpt.assembly.feature, and
org.eclipse.jpt_sdk.assebly.feature.
I also noticed that in my previous haste, I left some of the 'requires' features as having 4 fields instead of 3. Technically, this wouldn't cause any problems, but I think makes them read a little awkward, so recommend they be changed to 3 fields. For example, in org.eclipse.jpt.feature one example line is <import feature="org.eclipse.gef" version="3.4.0.v20080115-677-8082A5696H2748"/> which reads better, I think, if it says <import feature="org.eclipse.gef" version="3.4.0"/> If we ever wanted to be more precise, the right place to do that is probably in the manifest of the bundles that require the 4th field precision. Similarly for several others. One more thing, if we can count this as "clean up feature definition bug" :) Is that the "eclipselink" features to not say they "require jpt" ... seems they should, right? So, if someone selects (only) the eclipse link feature from "software updates" then the _whole_ jpt feature would be installed ... not just the exact plugins that eclipselink requires. If it is your intent to only install a subset of jpt plugins with eclipse link (and not, for example, jpt documentation, then that's fine ... but, should be explicit about that, then. thanks, (In reply to comment #2) > I suggest that the problematic features, > org.eclipse.jpt > org.eclipse.jpt.sdk > be deleted (not just renamed) > because their names are so confusing with the 'real' features. > > Then, replace them features where the feature ID (and the project name) has > "assembly" in the name. Our scripts (see buildutilities.xml) are written so > any feature with "assembly" anywhere in the id is removed automatically from > the zip files. > > So, the new ones would be something like > org.eclipse.jpt.assembly.feature, and > org.eclipse.jpt_sdk.assebly.feature. > I agree on the proposed change, and made the required changes. Modified scripts were checked in, and Dali map were released. Fixed. |