Bug 232806

Summary: Class name validation applied on in Session Bean wizard is wrong
Product: [WebTools] WTP EJB Tools Reporter: Kaloyan Raev <kaloyan>
Component: jst.ejbAssignee: Yavor Boyadzhiev <yavor.vasilev.boyadzhiev>
Status: CLOSED FIXED QA Contact: Kaloyan Raev <kaloyan>
Severity: normal    
Priority: P3 CC: dimitar.giormov
Version: 3.0Keywords: PII
Target Milestone: 3.1 M1Flags: kaloyan: review+
Hardware: PC   
OS: Windows XP   
Whiteboard: S1
Attachments:
Description Flags
patch
none
patch
kaloyan: iplog+
patch - fixed code formatting
none
patch v4 none

Description Kaloyan Raev CLA 2008-05-19 10:44:23 EDT
Steps to reproduce:
1. Call the Session Bean wizard. 
2. Enter the necessary fields on the first page. Click Next. 
3. On the second page clean the "Bean name" field. 

The validation error states: "Invalid Java class name: The type name '' is not a valid identifier". This looks like the validation made for the "Class name" field on the first page. The validation error should rather state "The bean name cannot be empty".
Comment 1 Milen Manov CLA 2008-06-18 06:23:21 EDT
*** Bug 232802 has been marked as a duplicate of this bug. ***
Comment 2 Yavor Boyadzhiev CLA 2008-06-18 08:41:13 EDT
Created attachment 105280 [details]
patch
Comment 3 Yavor Boyadzhiev CLA 2008-06-18 08:41:26 EDT
Created attachment 105281 [details]
patch
Comment 4 Kaloyan Raev CLA 2008-06-23 07:58:11 EDT
Created attachment 105626 [details]
patch - fixed code formatting
Comment 5 Kaloyan Raev CLA 2008-06-23 07:58:45 EDT
Patch looks OK. I just fixed some code formatting. 
Thanks!
Comment 6 Kaloyan Raev CLA 2008-06-30 11:03:21 EDT
The patch introduces new string for translation. 
Comment 7 Kaloyan Raev CLA 2008-07-01 03:58:06 EDT
Let's defer this for 3.1. 
Dimitar, please commit the patch to HEAD only. 
Comment 8 Kaloyan Raev CLA 2008-07-04 05:48:51 EDT
Created attachment 106563 [details]
patch v4

This latest version of the patch just resolves the code conflicts introduced with applying the patch of bug 225379.
Comment 9 Kaloyan Raev CLA 2008-07-04 09:08:39 EDT
Patch v4 committed to HEAD. 
Comment 10 Kaloyan Raev CLA 2008-08-04 09:52:15 EDT
Verified with wtp-sdk-I-3.1-20080801151537.