Summary: | [PropertiesView] should listen to partBroughtToTop also | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Richard Kulp <richkulp> |
Component: | UI | Assignee: | Eric Moffatt <emoffatt> |
Status: | RESOLVED WORKSFORME | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | gmendel, turnham, walkerp |
Version: | 2.0 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Windows 2000 | ||
Whiteboard: |
Description
Richard Kulp
2002-09-03 15:46:20 EDT
Could this be looked at please? It is still causing us problems. ContentOutline is example of where partBroughtToTop is handled. Thanks. The problem here is that the exception render the property sheet unusable when this occurs. All we need is to override in PropertySheet public void partBroughtToTop(IWorkbenchPart part) { partActivated(part); } The suggestion to simply handle 'partBroughtToTop' doesn't work here because the part that's brought to the top is the new editor (it's the new 'active' part), not the Outline View's corresponding page. I'll look into this a bit more... That's ok. It is the editor that we are interested in. The Outline page is associated with the new editor. So partBroughtToTop is the new editor and so the property sheet will select the correct property page for that new editor. Richard, the editor doesn't need the 'partBroughtToTop' handling, it already gets a 'partActivated' since the new editor is becoming the active part. In this scenario who is contributiing into the Property View...the editor or the outline view? The initial comment seems to indicate that it was the OutlinePage. This is no longer a problem because the sequence of events has changed. It used to be that if the outline view was active and you click the "x" and closed an editor, the outline view would stay active and another editor would be brought to top. But what has changed is that another editor is not brought to top but instead is activated and focus moved over to it and taken from the outline view. So now partActivated is called and the appropriate property sheet page is brought in. partBroughtToTop might still cause a problem but during my short little testing this morning I wasn't able to have partBroughtToTop by itself. It was always followed by a partActivated. |