Bug 231209

Summary:	[api][breaking] IRemoteFile.getSystemConnection() should be changed to IRemoteFile.getHost()
Product:	[Tools] Target Management	Reporter:	David McKnight <dmcknigh>
Component:	RSE	Assignee:	David McKnight <dmcknigh>
Status:	RESOLVED FIXED	QA Contact:	Martin Oberhuber <mober.at+eclipse>
Severity:	normal
Priority:	P3	CC:	rgerganov
Version:	3.0	Keywords:	api
Target Milestone:	3.0 RC2
Hardware:	All
OS:	All
Whiteboard:

Description David McKnight

2008-05-08 16:58:47 EDT

SystemConnection was renamed to IHost before moving RSE to open source so we shouldn't be using that name.

Comment 1 Martin Oberhuber

2008-05-09 01:42:38 EDT

We are past API freeze so I don't think this is worth it. But you can start a vote on the tm-dev mailing list and if a majority of committers is in favor of the change I will accept it.

Comment 2 David McKnight

2008-05-21 16:37:13 EDT

I've committed the changes to cvs.

Comment 3 Radoslav Gerganov

2008-05-22 05:09:15 EDT

Hm, I am getting lots of compile errors due to this change. You need to update all references to IRemoteFile#getSystemConnection() in the code.

Comment 4 Martin Oberhuber

2008-05-22 07:27:56 EDT

Rado, can you make the necessary fixes and commit? - i'd like to releaser current HEAD into an I-build as soon as possible, such that adopters can pick up recent API changes most quickly.

Comment 5 Radoslav Gerganov

2008-05-22 07:33:57 EDT

Martin, I am sorry but I am occupied with other stuff for the next 2 or 3 hours. Maybe I will be able to do the changes after that. Tell me if this works for you.

Comment 6 David McKnight

2008-05-22 09:08:58 EDT

My error list is messed up again and I'm not able to see any of these errors without going into the editor.  I'll try to get it working again so I can fix these.

Comment 7 David McKnight

2008-05-22 09:28:05 EDT

I had to change my preferences back to the defaults to see the errors.  I've committed the changes now.

Comment 8 Martin Oberhuber

2008-05-22 10:29:00 EDT

Summary of API Changes:
-----------------------

* IRemoteFile#getSystemConnection() has been renamed to #getHost()

Migration notes: client's build errors due to not finding getSystemConnection() must be fixed by renaming the getSystemConnection() method call to getHost().