Bugzilla – Full Text Bug Listing
| Summary: | [formatter] New comment put text over the max line length in some cases | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Frederic Fusier <frederic_fusier> | ||||
| Component: | Core | Assignee: | Frederic Fusier <frederic_fusier> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | daniel_megert, eric_jodet, jerome_lanneluc | ||||
| Version: | 3.4 | Flags: | jerome_lanneluc:
review+
|
||||
| Target Milestone: | 3.4 RC1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
The patch fixing this issue has been attached to bug 230230. Jerome can you please review? Released for 3.4RC1 in HEAD stream. using build I20080510-2000 and formatting attached file. Formatted javadoc is still: /** * Shutdown the HCR mgr and the Java debug targets. * * @see * org.osgi.framework.BundleActivator#stop(org.osgi.framework.BundleContext * ) text */ Expected formatted javadoc comment: /** * Shutdown the HCR mgr and the Java debug targets. * * @see org.osgi.framework.BundleActivator#stop(org.osgi.framework.BundleContext) * text */ (In reply to comment #3) > Expected formatted javadoc comment: > expect the @see and its reference to be on the same line This problem has been definitely fixed with bug 231263 patch... I should not have set this bug as fixed before the patch was released! Jerome, could you please review? Reviewed patch with Frederic: +1 Released for 3.4RC1 in HEAD stream. Verified for 3.4RC1 using build I20080513-2000 (this now works perfectly) |
Created attachment 98228 [details] Test case to illustrate the problem Using build I20080427-2000. The new formatter fails to format correctly the attached test case. The closing parenthesis should not be put on the same line than the reference as it makes the line over the max line length (80)