Bug 229453

Summary: Inappropriate build.properties errors for yet-to-be-built extra classpath jars that fail to update when the jar is built
Product: [Eclipse Project] PDE Reporter: Ed Merks <Ed.Merks>
Component: UIAssignee: Ed Merks <Ed.Merks>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: caniszczyk
Version: 3.4Keywords: bugday, contributed
Target Milestone: 3.4 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Mark missing plugins with the build.properties severity
none
Recheck the build.properties it there are PDE markers
none
Recheck the build.properties it there are PDE markers none

Description Ed Merks CLA 2008-04-29 15:12:48 EDT
When I extract the EMF source, none of the ant task jars are built and hence they don't exist yet.  References to missing jars on the jars.extra.classpath are flagged as errors which is really annoying because it means the newly extract source contains errors already.  It seems odd though that missing jars on the jars.compile.order aren't flagged at all while the ones on the jars.extra.classpath are flagged as errors.

jars.compile.order = .,\
                     ant_tasks/uml2.uml.ecore.importer.tasks.jar
jars.extra.classpath = ../org.eclipse.emf.ant/ant_tasks/emf.ant.tasks.jar

What makes it even more annoying is that when I actually build the jar, all these downstream errors in other projects don't go away until I clean each project.

Wouldn't it be better for this to be treated as a warning.

And to make this all exceedingly annoying, I can't even just create an empty jar to make the warnings go away because the build.xml isn't properly set up to depend on the .class files that go into the jar so the jar won't be rebuilt.  It's like all these things are stacked one on the other to make it impossible to work around this little annoyance.  We'll need to document all these steps for users setting up an development image from CVS (http://wiki.eclipse.org/EMF/Getting_Source), and that just helps highlight the underlying issues in the PDE, which otherwise is a like one of the crown jewels of Eclipse.
Comment 1 Ed Merks CLA 2008-05-06 12:43:24 EDT
Created attachment 98885 [details]
Mark missing plugins with the build.properties severity

Given that missing jars likely represent issues that a production build will correct later, I think problems for this should use the build.properties severity level rather than the classpath severity level; missing bundles is something more likely to represent a typo than something that a build will correct later...
Comment 2 Chris Aniszczyk CLA 2008-05-06 14:33:49 EDT
This is fair to me. It's confusing to try to debug why you're getting this error when it's a problem in the build.properties file.

Thanks for the patch Ed.
Comment 3 Chris Aniszczyk CLA 2008-05-06 14:35:00 EDT
done.

> 20080506
Comment 4 Ed Merks CLA 2008-05-06 16:21:06 EDT
Created attachment 98941 [details]
Recheck the build.properties it there are PDE markers

What do you think of this idea for checking the build.properties if there are markers.  I suppose we could even check if they are classpath-based markers...  I'll add that if you think this has merrit...
Comment 5 Ed Merks CLA 2008-05-06 16:30:24 EDT
Created attachment 98944 [details]
Recheck the build.properties it there are PDE markers

What do you think of this idea for checking the build.properties if there are markers.  I suppose we could even check if they are classpath-based markers...  I'll add that if you think this has merrit...
Comment 6 Nick Boldt CLA 2008-05-12 19:45:52 EDT
Fix available in HEAD: 2.4.0.I200805121800.