Bugzilla – Full Text Bug Listing
| Summary: | org.eclipse.jdt.internal.compiler.batch.Main writes bad characters to an xml log file | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | SAKAIRI Takashi <sakairi> | ||||
| Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | Olivier_Thomann, philippe_mulet | ||||
| Version: | 3.3.1 | ||||||
| Target Milestone: | 3.4 M7 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Thanks for the patch. Created attachment 96845 [details]
Proposed fix
Complete patch
Would you have a test case to add a regression case ? The fix is ready to be released. Released for 3.4M7. Takashi, could you please verify the fix with tomorrow's integration build ? Thanks. Philippe, since the fix is trivial, ok to backport to 3.3 maintenance ? Takashi is using 3.3.1 jar. Verified by reading the code +1 for 3.3 backport Backported for 3.3 maintenance stream. |
I called org.eclipse.jdt.internal.compiler.batch.Main.compile(String commandLine) method with "-log log.xml" option. log.xml contains bad UTF-8 characters. I modified several lines in public void setLog(String logFileName) throws InvalidInputException. * original this.log = new GenericXMLWriter(new FileOutputStream(logFileName, false), Util.LINE_SEPARATOR, true) * modified try { this.log = new GenericXMLWriter(new OutputStreamWriter(new FileOutputStream(logFileName, false), "UTF-8"), Util.LINE_SEPARATOR, true); } catch (UnsupportedEncodingException e1) { e1.printStackTrace(); // TODO } The modified code seems to work fine.