Bug 22695

Summary: [Reg] exception while connecting to remote site prevents continuation of one click update
Product: [Eclipse Project] Platform Reporter: Christophe Elek <celek>
Component: Update (deprecated - use Eclipse>Equinox>p2)Assignee: Dejan Glozic <dejan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 2.0   
Target Milestone: 2.0.1   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Christophe Elek CLA 2002-08-22 09:07:21 EDT 
While connecting (during one click update) received
java.net.ConnectException which prevents us from searching other sites.

I believe the code only check for java.io exception, we should check for
java.net exceptions too.
Comment 1 Christophe Elek CLA 2002-08-22 09:10:36 EDT 
Wrong assumption, I saw the search continuing and finding other sites.
the dialog showed (network error occured)
close as invalid
Comment 2 Christophe Elek CLA 2002-08-22 09:18:21 EDT 
Ok, when searching through regular search, root 1.0.1 is found, when using one
click update, it is not. 
Now, i check ed search bookmarked site in scope settings

is that normal or should it behave like regular search, i.e fail on http site,
then find update on file system and prompt user ?
Comment 3 Dejan Glozic CLA 2002-08-22 18:14:10 EDT 
Is this the issue of the update URL on Nevada?
Comment 4 Dejan Glozic CLA 2002-08-22 20:04:12 EDT 
Apparently, it is not. 

Search object created for both UM and one-click searches does the same thing: 
if makes a collection of candidate sites to visit, then loops through sites and 
looks for updates for candidate features. When connection exceptions are 
thrown, it does not terminate, rather it collects status objects and moves on 
to the next site.

When search is finished, it will throw the joint core exception using the 
collected status (merged into a multi-status). 

At this point, UM search simply displays the error message, but the result is 
shown after that without problems.

One-click update will show the error message as a problem, log it and quit. 

The fix is to check the multi-status result code and simply show the error but 
proceed because one-click update can turn results in spite of the connection 
problems.

The fix has been tested and it works well - it finds identical updates as the 
Update Manager search.
Comment 5 Christophe Elek CLA 2002-08-30 15:18:29 EDT 
fixed