Bug 226948

Summary: [api][regression] SystemNewFilterWizard.createNamePage() is no longer available
Product: [Tools] Target Management Reporter: Samuel Wu <samuelwu>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P1 CC: dmcknigh
Version: 3.0Keywords: api
Target Milestone: 3.0 M7   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch making SystemNewFilterWizardNamePage public and createNamePage() protected none

Description Samuel Wu CLA 2008-04-14 11:21:55 EDT 
We override the method SystemNewFilterWizard.createNamePage() to provide a wizard page of our own when creating a new filter. It seems the visibility of this method has been changed from protected to private recently, which broke our code.
Is there another way for us to override this wizard page?
Comment 1 David McKnight CLA 2008-04-14 16:12:54 EDT 
Martin, is it possible to bring back this API as protected?
Comment 2 Martin Oberhuber CLA 2008-04-21 09:03:10 EDT 
We probably did this, because SystemNewFilterWizardNamePage is "internal" and having the createNamePage() method protected created an API Leak.

I see, however, that the SystemNewFilterWizardInfoPage class is public API, and the corresponding createInfoPage() method is protected.

I thus agree that restoring the createNamePage() method as protected makes sense, and the SystemNewFilterWizardNamePage should be made public API for consistencey. Dave can you please check whether making that class API brings in any other API leaks, and attach a patch with the modified code if it works ok. If it doesn't lead to any other problems, I'm ok with restoring that API.

Please do this as early as possible such that we can get our API frozen.
Comment 3 David McKnight CLA 2008-04-21 10:10:38 EDT 
Created attachment 96852 [details]
patch making SystemNewFilterWizardNamePage public and createNamePage() protected
Comment 4 David McKnight CLA 2008-04-21 10:11:31 EDT 
I've created a patch for this.  I don't see any API leaks so I'll go ahead and commit to cvs.
Comment 5 David McKnight CLA 2008-04-21 10:13:15 EDT 
I've committed the changes to cvs.