Bug 226086

Summary:	[dstore][api][breaking] Move ServerLogger class to dstore.core bundle
Product:	[Tools] Target Management	Reporter:	Noriaki Takatsu <takatsu>
Component:	RSE	Assignee:	David McKnight <dmcknigh>
Status:	RESOLVED FIXED	QA Contact:	Martin Oberhuber <mober.at+eclipse>
Severity:	enhancement
Priority:	P1	CC:	dmcknigh, takatsu
Version:	3.0	Keywords:	api
Target Milestone:	3.0 M6
Hardware:	All
OS:	All
Whiteboard:

Description Noriaki Takatsu

2008-04-08 03:59:12 EDT

Now, ServerLogger comes to have non-static methods to support a single-process server model.
I've chosen EnvironmentMiner class as a place where the ServerLogger instance is created, since I thought that the EnvironmentMiner was always activated.
But the EnvironmentMiner is not activated when the USS facility is not constructed in a client and the client tries to connect to the server.  

So, it seems that the org.eclipse.dstore.core project is the best place to make ServerLogger instance.
But, ServerLogger class belongs to org.eclipse.rse.dstore.universal.miners
of org.eclipse.rse.services.dstore project.
This project has dependence on org.eclipse.dstore.core project.
Due to cyclic dependency, the class that belongs to org.eclipse.dstore.core project cannot invoke ServerLogger APIs.

To solve the above problem, I think that the ServerLogger class should be moved from org.eclipse.rse.services.dstore project to org.eclipse.dstore.core project.
Are there any solutions for this problem ?

Comment 1 Martin Oberhuber

2008-04-08 04:08:33 EDT

Suggestion sounds good to me. I changed the summary, previous value was:
Place where the ServerLogger instance is to be made

Note that repackaging is a breaking API change so this needs to be done NOW.

Comment 2 David McKnight

2008-04-08 10:36:43 EDT

I've moved ServerLogger to the org.eclipse.dstore.core.server package of the dstore.core plugin.