Bugzilla – Full Text Bug Listing
| Summary: | Generator writes repository many times | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | John Arthorne <john.arthorne> | ||||
| Component: | p2 | Assignee: | P2 Inbox <equinox.p2-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | Keywords: | performance | ||||
| Version: | 3.4 | ||||||
| Target Milestone: | 3.4 M7 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 94735 [details]
patch
Here is a potential patch. Note there was a comment in the original code about making sure the CUs are added before the product query is run but I don't see a product query in that method. Is the comment out of date?
The product query happens much later, in createProductIU. The comment is still relevant. Ok, I've resurrected the comment and added a bit more info and released the patch. Closing. |
Generator.generateBundleConfigIUs loops over all bundles, and creates a CU for each bundle that needs one. It then adds them to the repository one at a time: metadataRepository.addInstallableUnits(new IInstallableUnit[] {cu}); It should instead gather the CUs to add, and then add them all to the repository at once outside the loop. Otherwise, the repository file is being written once for each generated CU.