Summary: | [shells] Undo command doesn't work with Eclipse 3.4M5 | ||||||
---|---|---|---|---|---|---|---|
Product: | [Tools] Target Management | Reporter: | Radoslav Gerganov <rgerganov> | ||||
Component: | RSE | Assignee: | Radoslav Gerganov <rgerganov> | ||||
Status: | RESOLVED FIXED | QA Contact: | Martin Oberhuber <mober.at+eclipse> | ||||
Severity: | normal | ||||||
Priority: | P3 | CC: | daniel_megert | ||||
Version: | 3.0 | Flags: | mober.at+eclipse:
review+
|
||||
Target Milestone: | 3.0 M7 | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
Bug Depends on: | 221638 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Radoslav Gerganov
2008-03-04 14:57:13 EST
According to the Patform/Text guys it is not a good idea to query the undo manager in a listener. Currently we need to know if undo is possible in order to enable or disable the context menu action. I think that the fix should be to query the undo manager prior opening the context menu not in the textListener. I will propose a patch when I find some time. You should use org.eclipse.ui.operations.UndoActionHandler which takes care this. For details see: org.eclipse.ui.texteditor.AbstractTextEditor.createUndoRedoActions(). Rado can you look at this and implement it as proposed? - I'd like to have the alternative implementation in our M7 to make sure we can still give the Platform team some feedback in case we encounter unexpected issues. Created attachment 98139 [details]
patch using UndoActionHandler
Proposing patch using the UndoActionHandler for implementing undo.
I have tested on Eclipse 3.4M6 / Windows. Daniel, thanks for the help.
Marking as FIXED Patch looks good to me, please go ahead and commit Patch committed. |