Bug 220560

Summary: Regression in some open quick outline performance tests
Product: [Eclipse Project] JDT Reporter: Frederic Fusier <frederic_fusier>
Component: TextAssignee: Dani Megert <daniel_megert>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, martinae
Version: 3.4Keywords: performance, test
Target Milestone: 3.4 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Frederic Fusier CLA 2008-02-27 09:54:47 EST
Verifying build I20080226-1155, it looks like some open editors tests are red:
 - OpenQuickOutlineTest#testOpenQuickOutline1()-cold: between -4.8% and -49.8%
 - OpenQuickOutlineTest#testOpenQuickOutline1()-warm: between -8.4% and -39.3%
Comment 1 Frederic Fusier CLA 2008-02-27 09:56:01 EST
Bug description should obviously read: "...some open quick outline tests are red:"
Comment 2 Dani Megert CLA 2008-05-06 06:29:12 EDT
This is due to colored labels which are now enabled per default. The penalty is small when looking at absolute numbers (normally around 40ms, at most 80ms).

Closing as works for me, as the penalty is small. There's also an open bug report to even further improve the colored label performance (see bug 228017).

NOTE: between I20080207-1530 and I20080212-0800 an additional penalty can be seen. This is due to the switch to SimpleStyledCellLabelProvider. Maybe this is because the JFace story is a bit more generalized. Adding Martin and Boris in case they have some additional comments.
Comment 3 Dani Megert CLA 2008-05-06 08:08:57 EDT
.