Bug 220069

Summary: 'Plug-ins' view has a "malformed" content description
Product: [Eclipse Project] PDE Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Benjamin Cabé <contact>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: contact
Version: 3.4Keywords: contributed
Target Milestone: 3.4 M6   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Proposed patch
none
mylyn/context/zip none

Description Remy Suen CLA 2008-02-23 10:21:42 EST 
Build id: I20080212-0800

1. Make sure all instances of the 'Plug-ins' view is closed across all perspectives.
2. Open the 'Plug-ins' view.
3. See a weird content description for the view like 'Plug-ins: org.eclipse.pde.internal.ui.views.PluginsView$22@57479d'.

Needless to say, that's a toString() call on some anonymous inner class. The root cause is line 203 of the PluginsView class...

fTreeViewer.setInput(fRoot = getDeferredTreeRoot());

...which sets an IDeferredWorkbenchAdapter implementation as the input. The label provider being used for the tree viewer does not support this per lines 778 - 780...

String name = ((LabelProvider) fTreeViewer.getLabelProvider()).getText(newInput);
setContentDescription(viewName + ": " + name); //$NON-NLS-1$
setTitleToolTip(getInputPath(newInput));

...name, in this case, becomes org.eclipse.pde.internal.ui.views.PluginsView$22@57479d.

This is likely caused by the "lazy loading" change that was added to make the view to populate itself in a background job.
Comment 1 Benjamin Cabé CLA 2008-02-23 12:17:09 EST 
Created attachment 90552 [details]
Proposed patch

... it should do the trick!
Comment 2 Benjamin Cabé CLA 2008-02-23 12:17:12 EST 
Created attachment 90553 [details]
mylyn/context/zip
Comment 3 Chris Aniszczyk CLA 2008-02-23 12:37:30 EST 
ooo, thanks!
Comment 4 Chris Aniszczyk CLA 2008-02-23 12:38:23 EST 
thanks Ben!
Comment 5 Benjamin Cabé CLA 2008-02-23 12:42:06 EST 
you're welcome :)