Bugzilla – Full Text Bug Listing
| Summary: | Pathmap Manager doesn't support file-based pathmaps | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] GMF-Runtime | Reporter: | Chris McGee <cbmcgee> | ||||
| Component: | General | Assignee: | Chris McGee <cbmcgee> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | ahunter.eclipse | ||||
| Version: | 2.0 | Keywords: | contributed | ||||
| Target Milestone: | 2.1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Given that the Eclipse Linked Resources supports Files and Folders, it would seem logical that Path Maps also support Files and Folders. It is not clear to me that we need a second set of API to support files. In the PathmapManager API, we force a trailing / for a PATH, this is the underlying change we need fixed right? Yes, that is the problem. We have no way of knowing at the right points whether to append the trailing '/' to the pathmap URI or the value URI. Even if we did know it could be potentially expensive to try to resolve the URI to a workspace file/folder to determine which type it is. If there is a way to quickly autodetect this then it might be better than what is proposed here. Otherwise, the API must somehow differentiate. One more point about the new API is that it allows variables to be set in batches. This is really useful because settings a large number of variables currently forces the manager to do a normalize and denormalize cycle for every resource set for every new variable that is added. Please see bugzilla 225031 for a complete patch and test case. Committed to HEAD with Bug 225031 [target cleanup] 2.1 M6 was the original target milestone for this bug [GMF Restructure] Bug 319140 : product GMF and component Runtime EMF was the original product and component for this bug |
Created attachment 89989 [details] Proposed solution The pathmap manager currently has a restriction where pathmaps must be registered so that they point to a folder, not a file. Please find the attached patch as a proposal to add file-based pathmap support.