Bugzilla – Full Text Bug Listing
| Summary: | Make GEF's snapping and tools extensible to allow moving shapes with arrow keys | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | Cherie Revells <crevells> | ||||||
| Component: | GEF-Legacy GEF (MVC) | Assignee: | Cherie Revells <crevells> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | ahunter.eclipse | ||||||
| Version: | 3.4 | Keywords: | contributed | ||||||
| Target Milestone: | 3.4.0 (Ganymede) M5 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 111901 | ||||||||
| Attachments: |
|
||||||||
Created attachment 85579 [details]
updated patch
I've attached a patch that includes changes to AbstractTool. Specifically:
AbstractTool.Input.setMouseLocation() changed to public.
AbstractTool.placeMouseInViewer() changed to protected.
AbstractTool.acceptArrowKey() changed to protected.
History of why I need these changes (if interested)...
If I press the arrow key while the mouse is outside the diagram viewer, the new location of the shape is off. The reason is as follows:
- DragEditPartsTracker.handleKeyDown() is called when the arrow key is pressed.
- This sets the start location based on the current mouse location (which is outside the viewer).
- Then placeMouseInViewer(getLocation().getTranslated(0, accGetStep())) is called which not only moves the mouse by the translated amount, but also moves the mouse into the viewer (although the location in the current input is not updated)
- Later when getDragMoveDelta() is called to update the move delta in the request, the start location and current mouse location differ significantly affecting the move.
I have fixed this in GMF, by first moving the cursor to the center of the shape when an arrow key is pressed:
protected boolean handleKeyDown(KeyEvent e) {
if (acceptArrowKey(e)) {
if (isInState(STATE_INITIAL)) {
IGraphicalEditPart ep = (IGraphicalEditPart) getSourceEditPart();
if (ep != null) {
Point location = ep.getFigure().getBounds().getCenter();
ep.getFigure().translateToAbsolute(location);
placeMouseInViewer(location);
getCurrentInput().setMouseLocation(location.x, location.y);
}
}
}
return super.handleKeyDown(e);
}
Committed to HEAD |
Created attachment 85486 [details] patch I am changing the behavior of GEF in GMF so that the user can press an arrow key on a shape and this will move the shape. In order to do this, I would like to make a few changes in GEF, so that it is possible to extend GEF in this manner. I am attaching a patch that does the following: - Add getter for THRESHOLD in SnapToGuides so it can be overridden. This was already done in SnapToGeometry. - Make CompoundSnapToHelper.getDelegates() protected so subclasses can access the delegates. - Make TargetingTool.resetHover() protected so it can be called by subclasses to change the behavior of the SelectionTool. - Make GraphicalViewerKeyHandler.getNavigationSiblings() and isViewerMirrored() protected as they are useful for subclasses. - Extracted the snapping behavior into a new method snapPoint(request) in DragEditPartsTracker so that clients can customize the snapping behavior (I want to add extended data to the request to restrict the direction of snapping). Alex has code reviewed. Anthony, can you look at these changes and commit?