Bugzilla – Full Text Bug Listing
| Summary: | On JavaEditor dont use == in the isActivePart() method but instead use .equals(Object) | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Joe Winchester <Winchest> |
| Component: | UI | Assignee: | Kai-Uwe Maetzel <kai-uwe_maetzel> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | critical | ||
| Priority: | P3 | CC: | dirk_baeumer, Kevin_Haaland |
| Version: | 2.0 | ||
| Target Milestone: | 2.0.1 | ||
| Hardware: | PC | ||
| OS: | Windows 2000 | ||
| Whiteboard: | |||
Kai pls comment, this bug is on a fix wish list. To me it would be OK to consider for 2.1 but for 2.0.1 it is questionable. This code change is no problem for us. However, just for the record, this is not a blessing of embedding the editor into another part. There might be more problems when doing this. Change released to 2.0.1 and 2.1 stream. verified in code (2.0.1 - 20020821) |
The class JavaEditor does an == check inside isActivePart(). This means that if the part is embedded inside another one then the check fails. Rather than this can it use .equals instead and dispatch this to the other part that can specialize accordingly, e.g. instead of the current method protected boolean isActivePart() { IWorkbenchWindow window= getSite().getWorkbenchWindow(); IPartService service= window.getPartService(); return (this == service.getActivePart()); } it could have the last line as return (service.getActivePart().equals(this));