Bugzilla – Full Text Bug Listing
| Summary: | Several change navigation issues in compare editor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Manja Nelius <manja.nelius> | ||||
| Component: | Compare | Assignee: | Platform-Compare-Inbox <platform-compare-inbox> | ||||
| Status: | NEW --- | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | tomasz.zarna | ||||
| Version: | 3.3.1 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
I just realized that the posted fix is not complete. There are some situations in which the navigation still doesn't work correctly. So please don't understand it as a ready-to-integrate fix. Manja, I appreciate your work on this. I might be scratching the surface of this issue in bug 212738. The other one I can think of is bug 204157. I'm pretty sure there are others related bugs too. It doesn't mean you should take a look at all of them, what I mean is that fixing this bug could also help us with the others. If I could suggest anything, it'd probably be attaching patch files[1] instead of excerpts of code. Patches are the most common way of exchanging code modifications we're using here. They are much easier to check/verify too. [1] http://wiki.eclipse.org/index.php/CVS_FAQ#How_do_I_send_someone_a_patch.3F This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. |
Created attachment 84295 [details] excerpt of TextMergeViewer.java with fixes in various lines there are several problems in the compare editor when navigating the changes: 1st: when the cursor is positioned right in front of a change and the user selects "Next Change" not the change behind the cursor is selected, but the change after that one --> i would assume, that the change right after the cursor is selected when i press "Next Change" 2nd: "Previous Change" doesn't work; when i press the button, the whole diff line is selected, not the change before the current cursor position 3rd: whole line of the next diff is selected when the cursor is positioned behind the last change of the previous diff line and the user selects "Next Change" --> the natural navigation behaviour would be to select the first change of the next diff, not the whole line and only on the next "Next Change" the expected change see my suggested fixes in the attached file, which is an excerpt of TextMergeViewer.java, in the following lines: 15, 74, 94, 106, 118, 130, 151, 160, 165, 176, 178, 184, 187, 191, 206, 220, 232, 262, 275, 296