Bug 210627

Summary: Create Patch should sort diffs by file path
Product: [Eclipse Project] Platform Reporter: Markus Keller <markus.kell.r>
Component: CVSAssignee: Tomasz Zarna <tomasz.zarna>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: qualidafial
Version: 3.4   
Target Milestone: 3.6 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Fix v01
none
Fix v02
none
mylyn/context/zip none

Description Markus Keller CLA 2007-11-22 04:39:52 EST 
I20071120-1300

Create Patch should sort the diffs by project and file path (alphabetically). This would make it possible to compare two patch files by hand. It would also help users until bug 198149 is fixed.
Comment 1 Tomasz Zarna CLA 2007-11-22 09:06:13 EST 
AFAIK, cvs diff doesn't give us such option, but even if it did, it wouldn't be any helpful as there are several executions of the diff command which write to the same stream. So, we will need to do the sorting manually (on Eclipse side).
Comment 2 Matthew Hall CLA 2009-09-11 11:54:40 EDT 
This would be a wonderful enhancement for committers
Comment 3 Tomasz Zarna CLA 2009-09-17 06:58:00 EDT 
Created attachment 147425 [details]
Fix v01

Projects and files in the patch sorted by full path. The only problem remaining is that existing files always get first before new files (additions), these are two separate collections, but at least they're sorted within these groups. So this is not my last word, I will try to prepare v02 next week.
Comment 4 Tomasz Zarna CLA 2009-09-21 06:34:37 EDT 
Created attachment 147679 [details]
Fix v02

As promised. The patch fixes the "existing files always go before new files" issue.
Comment 5 Tomasz Zarna CLA 2009-09-21 06:34:43 EDT 
Created attachment 147680 [details]
mylyn/context/zip
Comment 6 Tomasz Zarna CLA 2009-09-21 06:44:07 EDT 
Fix v02 applied to HEAD, available in builds >N20090921.