Summary: | [ExternalTools] Cancel tool does not cancel tool | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Mads Pultz <mpultz> |
Component: | Ant | Assignee: | Jared Burns <jared_burns> |
Status: | VERIFIED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | jared_burns |
Version: | 2.0 | Keywords: | ui |
Target Milestone: | 2.1 M5 | ||
Hardware: | PC | ||
OS: | Windows 2000 | ||
Whiteboard: |
Description
Mads Pultz
2002-06-26 11:58:49 EDT
What build of Eclipse are you using? I'm using GM4. The problem also exist in F2 which I used before. "cancel" no longer exists. When you run an external program, a process is registered, which can now be terminated. Please verify, Jared. Reopening. When I click on the "Terminate" button, it doesn't stop the execution of my script. I've tested this with the exportplugins.xml script in the org.eclipse.jdt.debug.tests/scripts directory. The script runs to completion even if I click Terminate as soon as it starts. It only works for "programs" - not ant scripts currently. This is beacuse a program is a java.lang.Process (which supports terminate), and a script is a "fake" IProcess that does not support terminate. The terminate button is not enabled for ant scripts. Yes it is. :-/ If you launch the exportplugins script, you'll see that the terminate button in the debug view is enabled for the duration of its execution. Ah - it's only enabled when the "launch" is selected - not the process. There is actually a bug with the #canTerminate() method in Launch. not sure where this bug should be living? There are two bugs: (1) Debug platform - launch#canTerminate() (2) Support termiante for ant builds I will file a bug for (1) in the debug platform. This bug can stay here for (2) Fixed. The terminate button is now enabled, and terminates a build. I made the AntProcess into an IProgressMonitor, which is passed into the AntRunner. The AntRunner then checks for cancellation as tasks are processed. Please verify. I accidentally verified this one :-) |